Skip to content

Unpin clang-format in development requirements.#1100

Open
rosspeili wants to merge 3 commits into
tensorflow:masterfrom
rosspeili:unpin-clang-format
Open

Unpin clang-format in development requirements.#1100
rosspeili wants to merge 3 commits into
tensorflow:masterfrom
rosspeili:unpin-clang-format

Conversation

@rosspeili

@rosspeili rosspeili commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Remove the ~=18.1.0 constraint from requirements.in and refresh the locked clang-format entry in requirements.txt to 22.1.5. Closes #1084

Remove the ~=18.1.0 constraint from requirements.in and refresh the locked clang-format entry in requirements.txt to 22.1.5.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the clang-format documentation link in CONTRIBUTING.md, unpins clang-format in requirements.in, and updates dependencies in requirements.txt, including upgrading clang-format to 22.1.5 and adding colorama. However, it also downgrades tensorflow-io-gcs-filesystem from 0.37.1 to 0.31.0, which introduces a critical compatibility issue with tensorflow==2.19.1 and could lead to runtime failures.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread requirements.txt Outdated
Revert the locked clang-format bump to 22.1.5. Issue tensorflow#1084 only unpins requirements.in; CI format_check still uses the existing 18.1.8 lockfile entry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unpin clang-format version

1 participant